Fixed wakeup bug in NioOutboundPipeline #14831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pveentjer
force-pushed
the
v3.12/fix/wakeup-bug-NioOutboundPipeline
branch
from
587c1d9
to
f3acbac
Compare
kwart
reviewed
Apr 3, 2019
hazelcast/src/main/java/com/hazelcast/internal/networking/nio/NioOutboundPipeline.java
Show resolved
Hide resolved
kwart
reviewed
Apr 3, 2019
pveentjer
force-pushed
the
v3.12/fix/wakeup-bug-NioOutboundPipeline
branch
from
f3acbac
to
4d8d274
Compare
|
I have addressed your comment @kwart . Can you have another look? |
kwart
approved these changes
Apr 4, 2019
mmedenjak
reviewed
Apr 4, 2019
| private long isScheduled() { | ||
| return scheduled.get() ? 1 : 0; | ||
| private long scheduled() { | ||
| return scheduled.get().ordinal(); |
There was a problem hiding this comment.
This is rather unconventional. Any reason we can't use something like return scheduled.get() == State.SCHEDULED ? 1 : 0?
I'm thinking if someone changes the order. The value of this method returns as well.
mmedenjak
approved these changes
Apr 4, 2019
This was referenced Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14830.